search

umts / microservices-engine

Rails engine for attaching to our microservices and handling inter-service communication.
MIT License
0 stars 1 forks source link

Engine initialization errors should be less generic #26

Closed dfaulken closed 7 years ago

dfaulken commented 7 years ago

In https://github.com/umts/microservices-engine/blob/master/lib/generators/install/templates/microservices_engine.rb, we just raise strings. It'd be nicer to use more specific Exception objects.

ennukee commented 7 years ago

This looks to be fixed now, since we're using IOError and ArgumentError now?

dfaulken commented 7 years ago

I'll leave that call up to you and @Anbranin.

ennukee commented 7 years ago

I'll close it for now unless @Anbranin thinks otherwise.