search

umts / microservices-engine

Rails engine for attaching to our microservices and handling inter-service communication.
MIT License
0 stars 1 forks source link

should we not allow rails greater than 3.0? #29

Closed Anbranin closed 7 years ago

Anbranin commented 7 years ago

~> means allow greater minor version changes but not major. For example, ~> 2.1.0 would allow anything from 2.1.0 to 3.0 but no further. So, we've restricted ourselves to exactly rails 3 here.

werebus commented 7 years ago

I agree in principle since we intend to support multiple major versions. I wonder if we should put an upper limit on it indicating the highest version we've tried it on, e.g.

s.add_dependency 'rails', '>= 3.0', '< 6.0'
Anbranin commented 7 years ago

I agree with @werebus on this one.

Anbranin commented 7 years ago

@dfaulken, good?