umts / microservices-engine

Rails engine for attaching to our microservices and handling inter-service communication.
MIT License
0 stars 1 forks source link

Travis email settings don't work #30

Closed dfaulken closed 7 years ago

dfaulken commented 7 years ago
on_failure: change

seems not to work how we think it should, since we just always get emails.

werebus commented 7 years ago

The documentation is a bit ambiguous, but it says, "Emails are sent when, on the given branch...". (emphasis added) Does that mean that each new failing branch makes a new email, but further failing commits on a PR won't?

dfaulken commented 7 years ago

I could've sworn that I've seen emails about each of several successive failing commits on a master branch for some of our repos, but perhaps I'm mistaken.

Let's see what happens when #29 is merged.

ennukee commented 7 years ago

@dfaulken Fixed?

dfaulken commented 7 years ago

Yep, sorry.