search

umts / microservices-engine

Rails engine for attaching to our microservices and handling inter-service communication.
MIT License
0 stars 1 forks source link

Adding Simplecov #50

Closed ennukee closed 7 years ago

ennukee commented 7 years ago

title

addresses #44

Ignoring travis because it still has the weird issues that are fixed in #46. Will bring coverage up to 100% once this and #46 are merged.

ennukee commented 7 years ago

Since the other PR got merged, I'll probably work on getting the non-engine-migration setup to pass Travis here (as it looks to be working differently on external apps)

ennukee commented 7 years ago

@dfaulken Should all be fixed

@Anbranin also now passing Travis with your generate 'migration' part in the generator.

Anbranin commented 7 years ago

weird.

Anbranin commented 7 years ago

@enragednuke, when you run rspec locally (more than once) does it give you any errors?

ennukee commented 7 years ago

nope

Anbranin commented 7 years ago

huh. 👍

ennukee commented 7 years ago

Oh, wait. When I run it with the DISABLE_ROUTER_CHECKIN=true flag, some of them fail because it's expecting stuff from the initializer to run when it's disabled.