search

umts / microservices-ntdsurveys

Rails 5 microservice for tracking NTD passenger count surveys.
MIT License
0 stars 0 forks source link

Do we need is_public attribute of location? #26

Closed Anbranin closed 7 years ago

Anbranin commented 7 years ago

It appears this is what we're expecting: https://github.com/umts/microservices-ntdsurveys/blob/master/spec/models/survey_spec.rb#L47

I think the is_public attribute of location was used to find the distance between two actual trip_stops (example: if you have a bus stop, then a town-line(not public but still location), then a bus stop, you'd want the distance between the two bus stops).

Since that's the only thing the is_public attribute was used for (and, only public locations GO on surveys), I think we don't need that attribute--as long as we only give NTD-Surveys the trip stops with public locations.

dfaulken commented 7 years ago

Okay, so you're saying that you're going to omit this attribute from your API, and therefore we can omit it from this test? The 'we' here is slightly unclear.

Anbranin commented 7 years ago

Sorry yes, I meant "does NTD-surveys need the is_public attribute" of location But yes, I'm double-checking that I'm right--that NTD-surveys does not, in fact, require the is_public attribute of locatios from round-three--as long as only trip_stops with public locations are sent to it.

dfaulken commented 7 years ago

I see. You're correct, ntdsurveys has no use for this attribute. Let me know when you change your API, and I'll make that change in the test.