search

umts / pvta-multiplatform

Transit realtime app for mobile devices
Other
6 stars 5 forks source link

Walking directions #377

Closed Anbranin closed 7 years ago

Anbranin commented 7 years ago

Google does not provide arrival and departure times when public transit is not involved in a trip (so, if you're only walking). The app tried to fetch arrival and departure times anyways, so on trips where there was only walking (so from here to the campus store, for example), an error would be thrown trying to fetch a null value. Put an ngIf in there to check for existence and fetched those values only if they are present.

Anbranin commented 7 years ago

They absolutely do get walking directions.

akaplo commented 7 years ago

Travis is failing because of #378. Let's roll a fix for that into this PR. Far as I can tell, the fix should be in travis.yml and the README, wherein we have two options:

  1. Specify npm install -g ionic@^2.21 and remove your changes to package.json, or
  2. Specify npm install -g ionic@^3.0.0 and keep your changes to package.json. (since Travis got the new version of ionic and should be using your package.json, I'm not sure why it didn't install the plugin and succeed in the first place though?)