search

umts / pvta-multiplatform

Transit realtime app for mobile devices
Other
6 stars 5 forks source link

Favorites page #393

Closed mboneil10 closed 7 years ago

mboneil10 commented 7 years ago

Closes #388

mboneil10 commented 7 years ago

Needs toast.

mboneil10 commented 7 years ago

Also, a897643 is what I needed to do in order for ionic to work for me (#390). When #391 is merged, that commit can go away.

(Wow, this PR is a mess)

mboneil10 commented 7 years ago

Closed until toast is added

mboneil10 commented 7 years ago

New My Buses page. Notice "favorite" added to nav bar, URL, and headings. Icons in nav menu.

screen shot 2017-06-22 at 12 18 39 pm
mboneil10 commented 7 years ago

Routes and stops page toast function. Start with screen:

screen shot 2017-06-22 at 12 24 09 pm

Unfavorite first route:

screen shot 2017-06-22 at 12 24 21 pm

Favorite fourth route:

screen shot 2017-06-22 at 12 24 36 pm
mboneil10 commented 7 years ago

If anyone wants to see more screenshots of toast, let me know. I figured that one page (Routes and Stops on "Routes" tab) is enough.

mboneil10 commented 7 years ago

Closeup of nav menu

screen shot 2017-06-22 at 12 28 19 pm

Open to suggestions for different icons.

mboneil10 commented 7 years ago

Didn't mess up the tests 👍

akaplo commented 7 years ago

Interested in @sherson's opinion on the new Favorites page.

akaplo commented 7 years ago

This is not an easy task to accomplish. @mboneil10 you're doing a great job!

mboneil10 commented 7 years ago

I was trying to see if I could fast forward the branch, and checked by seeing if I could push. I could... Still needs more work done.

mboneil10 commented 7 years ago

An explanation of 5482d9c: I had to delete and clone multiplatform again. So I had to create a new branch off of master, change "my buses" to "favorites", and pull the work I'd already done from this PR.

edit: should have done this in a different order. As in, pull the work I'd already done and make the favorites changes. Going to do that now.

mboneil10 commented 7 years ago

Need to change the file names, too.

mboneil10 commented 7 years ago

Aaand hopefully the last thing; abstracting toast.

mboneil10 commented 7 years ago

The new toast message for favorites is generic. I can change it to incorporate whether a route or stop was added to favorites.

screen shot 2017-06-27 at 2 36 11 pm

Update: toast message for favorites is back to normal

mboneil10 commented 7 years ago

I think it's all set now for people to review.

mboneil10 commented 7 years ago 
Typescript Error
Property 'present' does not exist on type 'ToastController'.

😭

mboneil10 commented 7 years ago

I don't like the message right now. "Stop removed from Favorites" seems fine, but "Stop added from Favorites" does not. I'll update the ternary if statement.

akaplo commented 7 years ago

I'd like all other direct uses of the ToastController (like this one) to instead use a ToastService helper function, but this PR is already big enough, so I've opened #405 .