Closed mboneil10 closed 7 years ago
Needs toast.
Also, a897643
is what I needed to do in order for ionic to work for me (#390). When #391 is merged, that commit can go away.
(Wow, this PR is a mess)
Closed until toast is added
New My Buses page. Notice "favorite" added to nav bar, URL, and headings. Icons in nav menu.
Routes and stops page toast function. Start with screen:
Unfavorite first route:
Favorite fourth route:
If anyone wants to see more screenshots of toast, let me know. I figured that one page (Routes and Stops on "Routes" tab) is enough.
Closeup of nav menu
Open to suggestions for different icons.
Didn't mess up the tests 👍
Interested in @sherson's opinion on the new Favorites page.
This is not an easy task to accomplish. @mboneil10 you're doing a great job!
I was trying to see if I could fast forward the branch, and checked by seeing if I could push. I could... Still needs more work done.
An explanation of 5482d9c: I had to delete and clone multiplatform again. So I had to create a new branch off of master, change "my buses" to "favorites", and pull the work I'd already done from this PR.
edit: should have done this in a different order. As in, pull the work I'd already done and make the favorites changes. Going to do that now.
Need to change the file names, too.
Aaand hopefully the last thing; abstracting toast.
The new toast message for favorites is generic. I can change it to incorporate whether a route or stop was added to favorites.
Update: toast message for favorites is back to normal
I think it's all set now for people to review.
Typescript Error
Property 'present' does not exist on type 'ToastController'.
😭
I don't like the message right now. "Stop removed from Favorites" seems fine, but "Stop added from Favorites" does not. I'll update the ternary if statement.
Closes #388