search

umts / pvta-multiplatform

Transit realtime app for mobile devices
Other
6 stars 5 forks source link

Add cooperative gesture handling for maps on plan trip #398

Closed akaplo closed 7 years ago

akaplo commented 7 years ago

Closes #397. Adds "cooperative gesture handling" from the Maps API. Users will be familiar with this as "that annoying thing that makes me use two fingers to move the map," but I'm convinced this is better than what we had before.

When scrolling down the Schedule page after planning a trip, you'll see this (applies to touch-based devices only): image

Confirmed working on my Nexus with mobile-Chrome 58 and has no effect on my Mac on Chrome 59. @dfaulken, I know you don't know anything about pvtrack testing, but would you anticipate an integration test might be able to check functionality for this?

dfaulken commented 7 years ago

In generic terms, yes, mobile-centered integration tests would hopefully be able to spot a difference in functionality here.

akaplo commented 7 years ago

I'm gonna see if I can write a test for this before merging.

akaplo commented 7 years ago

I unfortunately don't know how to test this. I'll open an issue for it though and will continue to read about how to do so. In the meantime, this works.