search

umts / pvta-multiplatform

Transit realtime app for mobile devices
Other
6 stars 5 forks source link

Convert All Toast Usages Into Service Calls #405

Closed akaplo closed 6 years ago

akaplo commented 7 years ago

393 created the ToastService, which wraps displaying a Toast message into set of helper function(s). The PR was large and only Toasts on the Favorites page were converted to use the new service's helper functions. This issue will be resolved when all components present toasts by calling functions in the ToastService.

This issue will familiarize you with some of our components and services.

akaplo commented 7 years ago

See examples such as this one for what we're looking to remove, and examples like this for what we're looking to move to.

You'll need to add at least 1 helper function to the ToastService.