umts / pvta-multiplatform

Transit realtime app for mobile devices
Other
6 stars 5 forks source link

Too Much Toast? #409

Closed akaplo closed 7 years ago

akaplo commented 7 years ago

This commit added toasts on the Routes & Stops page when you favorite or unfavorite a route, but they don't hide themselves. You could end up with an annoying number of them, like so:

toast

Is this worth fixing?

mboneil10 commented 7 years ago

I find the amount of toasts to be saddening, too. Do you mean setting a duration for the favorite toast messages? We could add a duration to this line. If you mean hiding it, then that could be done with some sort of if statement in the toast service. Either way, I think this could be a quick fix but not top priority.

akaplo commented 7 years ago

Yup! Duration is a solution, or we could make the Toast service close an open Toast whenever it tries to make a new one.

mboneil10 commented 7 years ago

Granted, it's not like anyone is favoriting routes and stops wildly. But I could do this.