umts / pvta-multiplatform

Transit realtime app for mobile devices
Other
6 stars 5 forks source link

Improve deletion of routes and stops #412

Closed mboneil10 closed 7 years ago

mboneil10 commented 7 years ago

Closes #402

mboneil10 commented 7 years ago
screen shot 2017-08-01 at 4 52 02 pm

Notice that the items are more separated. Added the edit button instead of Add Routes or Add Stops. The dividing lines now fit to the width of the device, reason why I included the background in the shot.

mboneil10 commented 7 years ago

The dividing lines are built with a padding on the left of 16px. So, it's an ionic default. 😭

Edit: I don't think the padding on the left matters all that much. The messaging app for my phone handles messages in the same way, but I know that they're swipe-to-delete. That being said, I'm not sure if the right arrow that appears on the side of the item indicates that you should slide it.

mboneil10 commented 7 years ago

The arrow used to be the default icon on an ion-item but developers wanted freedom of choice. They are on the list items of the iphone, but none of the other platforms. The right arrow shows that an item is tappable -- possibly unrelated to this issue.

mboneil10 commented 7 years ago

It might be overkill to add an edit button that shifts all of the favorite routes/stops over to reveal a tap-to-delete button. After all, there's already that little modal to edit favorite routes and stops.

Aaaaand I realize I used the create button when I should have used the word "EDIT".

mboneil10 commented 7 years ago

Another thing to note. If we're pretending that the colorful route numbers are icon-like, then the text next to them should be in-line with the text for favorite stops. I think this could help with trying to get these items more item-like.

mboneil10 commented 7 years ago
screen shot 2017-08-01 at 10 33 29 pm

Now there's a noticeable space between the pin and favorite stops. I'd rather it look like this if it helps users understand that the items are in a list and can be swiped. I think alignment is something we had to change. Thoughts?

mboneil10 commented 7 years ago
screen shot 2017-08-02 at 10 07 03 am
bandogora commented 7 years ago

Can you upload a screenshot of the apps in edit mode?

mboneil10 commented 7 years ago
screen shot 2017-08-02 at 2 56 05 pm

In desktop

mboneil10 commented 7 years ago
screen shot 2017-08-02 at 3 28 17 pm

Mobile