umts / pvta-multiplatform

Transit realtime app for mobile devices
Other
6 stars 5 forks source link

Rework Stop Dropdown (Again) #422

Closed akaplo closed 7 years ago

akaplo commented 7 years ago

Closes #407 in a continuation of #384.

Left: Android styling for sort-by-time Right: iOS styling for sort-by-RouteDirection with 1 Route expanded image

The desktop version image

mboneil10 commented 7 years ago

I merged with master. Was there a code-related reason you hadn't done so? I figured it would be okay, but the commit can be reverted if needed.

mboneil10 commented 7 years ago

@werebus has mentioned Material Designs specs before, and I think in this case I see something that could be changed. The stop dropdown arrows could be pointing down when they are collapsed and up when they are expanded. This way, we'd indicate that this item is expandable, instead of a menu item.

mboneil10 commented 7 years ago

Another thing: OOC, when did we start displaying destinations? What is the purpose? For Bus Garage destinations, or...?

akaplo commented 7 years ago

Good question - when ordering departures by Direction, there can be multiple departures with the same direction but different destinations, so it's nice to specify the destination in each entry.

The first screenshot in this PR shows an example - two 31s are leaving Studio Arts, one to Sunderland and one to the Garage. On the left, we see them both cause we order by time, but on the right they're grouped together, because they're both headed North.

dfaulken commented 7 years ago

Bus Garage is the major case for UMass, but on the whole, the other two PVTA properties have more variants per route than we do. So yes, buses can be leaving from the same stop, on the same route, and in the same direction — but still be going different places once they depart.

mboneil10 commented 7 years ago

Alright, sounds good. Thank you. @dfaulken @akaplo

akaplo commented 7 years ago

@mboneil10 good point about the arrow directions.

akaplo commented 7 years ago

Arrows and screenshots updated. @mboneil10 or anyone else - any final thoughts?

mboneil10 commented 7 years ago

Wait wait wait, it's the other way.

mboneil10 commented 7 years ago

I can make this fix for you @akaplo

mboneil10 commented 7 years ago
screen shot 2017-08-30 at 9 59 27 am
mboneil10 commented 7 years ago
screen shot 2017-08-30 at 10 01 09 am
akaplo commented 7 years ago

Woops! My bad. Thanks @mboneil10 👍