Closed akaplo closed 7 years ago
I merged with master. Was there a code-related reason you hadn't done so? I figured it would be okay, but the commit can be reverted if needed.
@werebus has mentioned Material Designs specs before, and I think in this case I see something that could be changed. The stop dropdown arrows could be pointing down when they are collapsed and up when they are expanded. This way, we'd indicate that this item is expandable, instead of a menu item.
Another thing: OOC, when did we start displaying destinations? What is the purpose? For Bus Garage destinations, or...?
Good question - when ordering departures by Direction
, there can be multiple departures with the same direction but different destinations, so it's nice to specify the destination in each entry.
The first screenshot in this PR shows an example - two 31s are leaving Studio Arts, one to Sunderland and one to the Garage. On the left, we see them both cause we order by time, but on the right they're grouped together, because they're both headed North.
Bus Garage is the major case for UMass, but on the whole, the other two PVTA properties have more variants per route than we do. So yes, buses can be leaving from the same stop, on the same route, and in the same direction — but still be going different places once they depart.
Alright, sounds good. Thank you. @dfaulken @akaplo
@mboneil10 good point about the arrow directions.
Arrows and screenshots updated. @mboneil10 or anyone else - any final thoughts?
Wait wait wait, it's the other way.
I can make this fix for you @akaplo
Woops! My bad. Thanks @mboneil10 👍
Closes #407 in a continuation of #384.
Left: Android styling for sort-by-time Right: iOS styling for sort-by-![image](https://user-images.githubusercontent.com/7144148/29853159-41729890-8d0c-11e7-8af9-5d2e01df65f6.png)
RouteDirection
with 1 Route expandedThe desktop version![image](https://user-images.githubusercontent.com/7144148/29853176-542195cc-8d0c-11e7-890d-6e0ffb4d1739.png)