umts / pvta-multiplatform

Transit realtime app for mobile devices
Other
6 stars 5 forks source link

Center pagination controls #430

Closed mboneil10 closed 6 years ago

mboneil10 commented 7 years ago

Closes #419

mboneil10 commented 7 years ago

Still need to:

mboneil10 commented 7 years ago

@akaplo, should I make a new scss file to remove padding and make a specific class for styling the pagination thing? I don't know what the best approach would be in terms of ionic. edit: yes, that's what is expected of the user. I can read again.

mboneil10 commented 7 years ago

I'll just do it anyway. That's what PRs are for!

akaplo commented 7 years ago

Go for it! You def don't need a new .scss file - we have one for each page plus a global one already, so you can just make your edits in the appropriate place.

mboneil10 commented 7 years ago

Thanks @akaplo

mboneil10 commented 7 years ago

Idk what's happening with this. I can't apply style in the way that the guide tells us to, and I've already tried every variation of using the different classes that pagination has. What I've done is put the "proper" syntax up here for anyone to look at. (Although I don't think that does much).

Should we still focus on getting the tappable area larger?

akaplo commented 7 years ago

This is a tough one indeed. I've played around with your changes, but also with no real luck. What you're doing seems correct to me.

mboneil10 commented 6 years ago

I'll close this since I couldn't figure it out. Maybe someone else will be able to.