search

umts / pvta-multiplatform

Transit realtime app for mobile devices
Other
6 stars 5 forks source link

Tappable Favorite Routes #441

Closed mboneil10 closed 6 years ago

mboneil10 commented 6 years ago

Closes #417

mboneil10 commented 6 years ago

The problem was with the columns not being tappable. Alternatively, I could have made the columns tappable and made the click event link to checking the checkbox. Whatever people like more. Personally, I like how I did it better.

mboneil10 commented 6 years ago
screen shot 2017-10-03 at 9 44 55 am
mboneil10 commented 6 years ago
screen shot 2017-10-03 at 9 46 09 am
mboneil10 commented 6 years ago

Compare with

screen shot 2017-10-03 at 9 47 40 am screen shot 2017-10-03 at 9 48 36 am
mboneil10 commented 6 years ago

The columns make the text align, but the huge white space in between is kind of weird.

mboneil10 commented 6 years ago

Did I make an oops? @akaplo

akaplo commented 6 years ago

Yeah, making them <div>s removed all the flexbox spacing the ion-cols were giving you for free.

I think the real issue has to do with how the row and columns exist inside the ion-label.

mboneil10 commented 6 years ago

Confusion with messages. However, this version now works.