umts / pvta-multiplatform

Transit realtime app for mobile devices
Other
6 stars 5 forks source link

Maps fix #470

Closed mboneil10 closed 5 years ago

mboneil10 commented 5 years ago

Closes #468

mboneil10 commented 5 years ago

NO Travis, why

mboneil10 commented 5 years ago

I thought updating the package-lock.json would fix the Travis build.

mboneil10 commented 5 years ago

Still investigating the CI build fails. Haven't figured out anything.

werebus commented 5 years ago

Two comments:

  1. The "dev" key — the one that can't cost us money — can be used on all platforms. In fact, it's fine if it's a key that renders the "for development purposes only" watermark.
  2. I can't tell by reading the code, but I wanted to explicitly say that any key that isn't ether capped to not exceed the free limits or limited to our apps and web site shouldn't be committed to this repo.
mboneil10 commented 5 years ago

@werebus

  1. Got it, makes sense.

  2. Wait, what? Where do I put those keys that aren't capped then?

mboneil10 commented 5 years ago

Hello, I forgot to keep everyone updated on the Google Cloud-side of things. So, I've done the following as of creating this repo:

Made four separate keys for the API maps. 1) Three are located in the project "PVTrAck"

mboneil10 commented 5 years ago

I'll also have to invert the if statements. On that.

Anbranin commented 5 years ago

Wait, what? Where do I put those keys that aren't capped then?

~You can put them in the application, just not on Github. You know how the database.yml file for Rails applications isn't on Github? We make the file directly on the server, and edit it there. Same deal. For this, though, I think you can restrict the keys to the application...? Am I wrong about that?~

Oh you already did the things

mboneil10 commented 5 years ago

@anbranin, thanks! Yeah, @werebus and I talked about that this morning. I was like, "oh yeah. That's how we do it everywhere else".

mboneil10 commented 5 years ago

Ok, so Travis passes. I'm getting a few errors still in the provider. I'll be fixing those ASAP.

mboneil10 commented 5 years ago

Closing until I figure it out completely.