umutphp / php-docker-images-for-ci

A repository with a set of Docker files created from official PHP images with some CI tools.
MIT License
28 stars 4 forks source link

Unset COMPOSER_BIN_DIR Variable #5

Closed umutphp closed 2 years ago

umutphp commented 5 years ago

In composer files, the COMPOSER_BIN_DIR is set to /usr/local/bin in Dockerfile as below to get the commands in global scope.

ENV COMPOSER_BIN_DIR="/usr/local/bin"

We need to unset the variable just after the end of composer package installations in Dockerfile.

ig-onoffice-de commented 2 years ago

This caused me an error. It should be reset to vendor/bin not to an empty string. Reset it on my own before running composer install and now it works for me. You could probably also unset the variable.

umutphp commented 2 years ago

Hi @ig-onoffice-de ,

Many thanks for the comment :).

Let me check your solution and update you.

umutphp commented 2 years ago

Hi @ig-onoffice-de ,

Fixed accordingly. Many thanks for the feedback.

exussum12 commented 2 years ago

FYI this caused an issue for us, its most likely unique to the way our code was set up.

For future people with maybe the same issue, check the versions when you call phpmnd and the version in the composer.lock / composer.json