un-fao / calipseo-shiny

Calipseo is FAO web- based platform for national Fisheries Authorities to streamline management of fisheries data and the production, analysis and reporting of fishery statistics.
1 stars 0 forks source link

[CALR-85] Vessel details - Issue with vessel history (when no data?) #85

Closed eblondel closed 6 months ago

eblondel commented 6 months ago

Issue migrated from JIRA: https://sdlc.review.fao.org/jira/browse/CALR-85 Creator/Reporter: Emmanuel Blondel @eblondel Assignee: Brian Ojok @brianandy Priority: Medium Status: Done Date of creation: 2022-04-13T21:16:23.000+0000

To replicate the error, select the boat 'Pamela' from Suriname (reg number = SK01136)

In the vessel history e get:

Error: character string is not in a standard unambiguous format

Stacktrace: {noformat} Warning: Error in as.POSIXlt.character: character string is not in a standard unambiguous format 130: stop 129: as.POSIXlt.character 126: as.POSIXct.default 124: [<-.POSIXct 122: [./modules/core/vessel_info_server.R#156] 106: historical_df 103: exprFunc [./modules/core/vessel_info_server.R#184] 102: widgetFunc 101: func 88: renderFunc 87: renderFunc 83: renderFunc 82: output$vessel_info-vessel_history 1: runApp{noformat}

eblondel commented 6 months ago

Author: Emmanuel Blondel @eblondel Date of creation: 2022-04-14T22:33:53.816+0000 Last update: 2022-04-14T22:33:53.816+0000

[~brian.ojok] can you briefly explain what was wrong?

eblondel commented 6 months ago

Author: Brian Ojok @brianandy Date of creation: 2022-04-15T09:03:43.288+0000 Last update: 2022-04-15T09:03:43.288+0000

[~emmanuel.blondel] the POSIXct date format was not being regonised because the loop that was supposed to convert empty rows to string 'NULL' was affecting the spaces within the date format