un-ts / changesets-gitlab

GitLab CI cli for changesets like its GitHub Action.
https://opencollective.com/unts/projects/changesets-gitlab
MIT License
89 stars 34 forks source link

refactor: improve internal usage of environment variables with prepared env #142

Closed alan910127 closed 11 months ago

alan910127 commented 11 months ago

Closes #141

Summary

changeset-bot[bot] commented 11 months ago

⚠️ No Changeset found

Latest commit: d3ad967173a31e07d3789f831d51140fcae0db1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codesandbox-ci[bot] commented 11 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

JounQin commented 11 months ago
image

Sorry you'll need to add a moduleNameMapper for jest:

{
  "moduleNameMapper": {
    "^(\\.{1,2}/.*)\\.js$": "$1"
  }
}
JounQin commented 11 months ago

It's really a great PR, thanks @alan910127 !

JounQin commented 11 months ago

By the way, the commit subject should be refactor, it doesn't change any runtime behavior.

JounQin commented 11 months ago

Thanks again, and sorry for my nitpicking.