search

un-ts / changesets-gitlab

GitLab CI cli for changesets like its GitHub Action.
https://opencollective.com/unts/projects/changesets-gitlab
MIT License
86 stars 33 forks source link

fix: keeps commenting on every push #153

Closed alan910127 closed 9 months ago

alan910127 commented 9 months ago

Closes #145

Summary

This is mostly reverting #143 while keeping the format of not using ReturnType as the type of parameter of the hasChangesetBeenAdded function.

changeset-bot[bot] commented 9 months ago

🦋 Changeset detected

Latest commit: 2d7773fb0c546599bb8a6bfa6d9d05479962d2be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | changesets-gitlab | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codesandbox-ci[bot] commented 9 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

JounQin commented 9 months ago

No compatible replacement? So this is an upstream issue? Is this a related upstream issue for reference?

@alan910127 I think we should check the version of GitLab instance to determine which method/API should be used. But considering the repeating comments issue, I'll merge this PR first.

alan910127 commented 9 months ago

@JounQin I could try to solve the issue with allDiffs 😄