un-ts / markuplint

Incredible markuplint plugins, make markuplint greater.
MIT License
4 stars 7 forks source link

feat: markuplint-angular-parser supports v2 #73

Closed YusukeHirao closed 2 years ago

YusukeHirao commented 2 years ago

I heard users hope the angular parser supports. I support this package because I complete upgrading the basic API of markuplint to v2.

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 9de318c1ee336c29de199b041ffe1119cbf7473a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

YusukeHirao commented 2 years ago

Hi @JounQin.

Please review this.

codecov[bot] commented 2 years ago

Codecov Report

Merging #73 (b16af2c) into main (415ecd9) will decrease coverage by 0.29%. The diff coverage is 100.00%.

:exclamation: Current head b16af2c differs from pull request most recent head 9de318c. Consider uploading reports for the commit 9de318c to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   82.52%   82.22%   -0.30%     
==========================================
  Files          24       24              
  Lines         475      467       -8     
  Branches      117      113       -4     
==========================================
- Hits          392      384       -8     
  Misses         77       77              
  Partials        6        6              
Impacted Files Coverage Δ
packages/angular-parser/src/index.ts 98.87% <100.00%> (-0.10%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 415ecd9...9de318c. Read the comment docs.

YusukeHirao commented 2 years ago

@JounQin

I'm sorry. It didn't pass the tests.

I think you should revert it. I guess fail to design about isInvalid. The @markuplint/html-parser doesn't use isInvalid. The @markuplint/pug-parser uses isInvalid for the parse error. So the invalid-attr rule doesn't use the isInvalid property.

I think the rule must use the property and I'm going to change it.

JounQin commented 2 years ago

@YusukeHirao Would you like to PR again? I don't have much time working on it recently. 😭

YusukeHirao commented 2 years ago

@JounQin Yes, I will do now. Please a moment.