search

un-ts / prettier

:package: Opinionated but Incredible Prettier plugins.
https://prettier.vercel.app
MIT License
274 stars 25 forks source link

`prettier-plugin-sql` uppercase broken #254

Closed JoernBerkefeld closed 1 year ago

JoernBerkefeld commented 1 year ago

I'm running prettier on SQL files and in the past that would have nicely uppercased the query as well. at some point that stopped working though. My config: image

test-sql:

Select
    f.Id as ContactId,
    f.EndDate,
    f.StartDate,
    SecondReminder,
    f.Enabled,
    f.CustomerSegment
from
    test f
    inner join test2 s on f.Seller = s.Seller

the above is one out of many I tried - haven't seen it working anywhere.

i tried playing with the uppercase value, setting it as a string for instance, but that lead to an error.

JounQin commented 1 year ago

Did you tried keywordCase: 'upper'?

JoernBerkefeld commented 1 year ago

thanks for letting me know, @JounQin

I do appreciate all your work here!

Small ask though: Could you please include changes like this one in the CHANGELOG.md going forward?

I looked at the README.md history to understand when this was changed and based on that history you must have updated that on or before July 21, 2022. That date matches release 0.10.0.

With this being a breaking change, I would have hoped to see a major version increase (see semver), but at the very least, I would assume that this is mentioned in the changelog.

I'm sure I'm not the only one that has your package as a dependency and I tend to rely on changelogs and type of version changes to understand if I need to take a closer look or can just upgrade. With neither happening, it makes it very difficult to work with it :(

JounQin commented 1 year ago

The package follows semver but it is still 0.x, so 0.9 -> 0.10 means breaking changes.

Since we're using sql-formatter inside, so I think maybe it would be worth to mention its breaking change in CHANGELOG of course, sorry I didn't do it before.

JoernBerkefeld commented 1 year ago

Thank you!

I did skim through the semver definition but couldn't directly find what you are stating - it does however say that 0.x is unstable at all times which I suppose is what you refer to. They recommend moving to 1.0 as soon as it's used in production.

Well - it IS used in production ;-) time to stand behind your product. it's doing a good job for the users of https://www.npmjs.com/package/mcdev / https://github.com/Accenture/sfmc-devtools and I'm sure for many more out there

JoernBerkefeld commented 1 year ago

oh and - can confirm it's working like a charm. will include the change in my next release. thanks again for solving this for me