search

un-ts / prettier

:package: Opinionated but Incredible Prettier plugins.
https://prettier.vercel.app
MIT License
261 stars 23 forks source link

prettier-plugin-sql: Update to sql-formatter@14? #313

Closed karlhorky closed 7 months ago

karlhorky commented 7 months ago

Hi @JounQin, hope you're well! 👋

I saw that there was a new version sql-formatter@14.0.0, which introduces a new identifierCase option

2 breaking changes, apparently removal of options which were already deprecated and broken:

Breaking changes

These already deprecated features were fundamentally broken and have been removed for good:

  • Removed tabulateAlias config option.
  • Removed commaPosition config option.

What do you think about upgrading to this new major version?

JounQin commented 7 months ago

PR welcome, I think that would be very smooth by just upgrading dependencies adding a new option.

karlhorky commented 7 months ago

Ok, PR open at: