search

un-ts / prettier

:package: Opinionated but Incredible Prettier plugins.
https://prettier.vercel.app
MIT License
261 stars 23 forks source link

feat!: add `toml` plugin, use `taplo` inside instead #314

Closed so1ve closed 7 months ago

so1ve commented 7 months ago

resolves https://github.com/un-ts/toml-tools/issues/72, fixes https://github.com/un-ts/toml-tools/issues/74

changeset-bot[bot] commented 7 months ago

šŸ¦‹ Changeset detected

Latest commit: 2293cca3d0374f465b2fc8481974e205bd05a768

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | prettier-plugin-toml | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codesandbox-ci[bot] commented 7 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

so1ve commented 7 months ago

@JounQin Done

JounQin commented 7 months ago

Hi @so1ve, do you want to be a collaborator of this repository or a member of @un-ts organization? Of course, it's OK if you don't want to.

so1ve commented 7 months ago

I want to be a part of this organizationā¤ļø

JounQin commented 7 months ago

I want to be a part of this organizationā¤ļø

Welcome @so1ve !

codecov[bot] commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ac2b2fb) 88.00% compared to head (2293cca) 87.27%.

Files Patch % Lines
packages/toml/src/index.ts 78.57% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #314 +/- ## ========================================== - Coverage 88.00% 87.27% -0.73% ========================================== Files 8 10 +2 Lines 150 165 +15 Branches 41 45 +4 ========================================== + Hits 132 144 +12 - Misses 17 20 +3 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JounQin commented 7 months ago

Thanks and welcome again, and sorry for my nitpicking.

JounQin commented 7 months ago

@so1ve I believe https://github.com/so1ve/prettier-plugin-taplo can be archived and https://www.npmjs.com/package/prettier-plugin-taplo can be deprecated now?

so1ve commented 7 months ago

sorry for my nitpicking

Never mind, now the code quality is much better :)

I believe so1ve/prettier-plugin-taplo can be archived and npmjs.com/package/prettier-plugin-taplo can be deprecated now?

Done!