un-ts / prettier

:package: Opinionated but Incredible Prettier plugins.
https://prettier.vercel.app
MIT License
274 stars 25 forks source link

[prettier-plugin-toml] unable to format `toml` programmatically in an es module #317

Closed Sec-ant closed 10 months ago

Sec-ant commented 10 months ago

Following setup:

JounQin commented 10 months ago

Thanks for reporting, I'll fix this quickly.

Sec-ant commented 10 months ago

A bit of a tangent: can you also export the type PrettierTaploOptions so I can add this plugin in prettier-plugin-embed with the proper type for the options?

JounQin commented 10 months ago

A bit of a tangent: can you also export the type PrettierTaploOptions so I can add this plugin in prettier-plugin-embed with the proper type for the options?

Sure~

JounQin commented 10 months ago

@Sec-ant Is your request here the same thing as #311?

Sec-ant commented 10 months ago

@Sec-ant Is you request here the same thing as #311?

Sort of. I'd love a string literal union type of SqlBaseOptions["language"] and SqlBaseOptions["database"]. But they're just string right now.

But I don't think that matters that much right now. Because I just discarded dialect mapping. I can close that issue. @JounQin

JounQin commented 10 months ago

OK, let's close it then.