un-ts / prettier

:package: Opinionated but Incredible Prettier plugins.
https://prettier.vercel.app
MIT License
260 stars 23 forks source link

feat: add sql-formatter `dialect` option #334

Closed karlhorky closed 6 months ago

karlhorky commented 6 months ago

Closes #322

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: b920ac4f193bc15141214f9e9cb77748aa5ceaaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | prettier-plugin-sql | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (909e30a) 87.80% compared to head (b920ac4) 88.16%.

Files Patch % Lines
packages/sql/src/index.ts 85.71% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #334 +/- ## ========================================== + Coverage 87.80% 88.16% +0.36% ========================================== Files 10 10 Lines 164 169 +5 Branches 44 46 +2 ========================================== + Hits 144 149 +5 Misses 19 19 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JounQin commented 6 months ago

Can you add a test case? LGTM beyond this.

JounQin commented 6 months ago

Thanks for your contributions!

karlhorky commented 6 months ago

Glad to help :) thanks for your guidance, and the review and merge!