search

un33k / impacket

Automatically exported from code.google.com/p/impacket
Other
8 stars 3 forks source link

Incoherent doc for byte-order format specifiers, and doc typos #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Reported by Yann Dirson: 
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703784 :

in the impacket.structure.Structure doc:

 |      >       [little endian]
...
 |      <       [little endian]
 |      >       [big endian]

other typos exist:

 |      Q       [unsigned long ong (quad)]

and it includes literal \x00 in the docstring, where they should
probably have been entered as \\x00, or the docstring should have
been made a raw string.

Original issue reported on code.google.com by dsdeb...@gmail.com on 28 May 2013 at 1:49

GoogleCodeExporter commented 9 years ago 
Hey Yann... 

thanks for the report... 

I can't find this part you reported:

 |      >       [little endian]
...
 |      <       [little endian]
 |      >       [big endian]

I only see the last part (correct one).

Where did you find it?

thanks
beto

Original comment by bet...@gmail.com on 29 May 2013 at 1:35

GoogleCodeExporter commented 9 years ago 
Hi,

Actually, I have just uploaded version 0.9.10 to Debian, but this bug was 
initially reported against version 0.9.6. After checking, little/big endian 
documentation issue seems to have been fixed in 0.9.10, even though other 
reported typos seem to still apply. Sorry about that.

Arnaud

Original comment by dsdeb...@gmail.com on 30 May 2013 at 2:42

GoogleCodeExporter commented 9 years ago 
Arnaud:

I just committed this changeset 
http://code.google.com/p/impacket/source/detail?r=765 .. Let me know if you 
think there's something else to fix. If not I'll close this ticket.

thanks for the report!
beto

Original comment by bet...@gmail.com on 31 May 2013 at 3:54

GoogleCodeExporter commented 9 years ago 
I don't think there is anything else. Thanks for your responsive reply!

Original comment by dsdeb...@gmail.com on 6 Jun 2013 at 2:07

GoogleCodeExporter commented 9 years ago 
Arnaud:

That´s great... I´m closing the ticket..

thanks for the report!

beto

Original comment by bet...@gmail.com on 6 Jun 2013 at 4:00