search

un33k / node-ipware

Returns the real IP address of users in Node.js
MIT License
124 stars 17 forks source link

BUGFIX: set is_initialized to true #1

Closed tmikov closed 9 years ago

tmikov commented 9 years ago

is_initialized was never set, so initialization was performed every time.

un33k commented 9 years ago

Great catch. Thx

tmikov commented 9 years ago

You are welcome. It was causing some performance problems, as you can imagine :-) Could you please publish a new version of the NPM - we depend on it in our package 'blpapi-http'.

un33k commented 9 years ago

IP check should be done only once per session and the result stored in the session. Unless it is used differently.

Anyways, I will push a new version on today or tomorrow. Thx.

On 1/8/15, Tzvetan Mikov notifications@github.com wrote:

You are welcome. It was causing some performance problems, as you can image :-) Could you please publish a new version of the NPM - we depend on it in our package 'blpapi-http'.

Reply to this email directly or view it on GitHub: https://github.com/un33k/node-ipware/pull/1#issuecomment-69252628

un33k commented 9 years ago

FYI: version 0.0.3 is push to npm. thanks.

tmikov commented 9 years ago

Thank you so much! I appreciate it.

About storing the IP in the session: I have been thinking about it, but a session could jump between IPs (either naturally or maliciously). So, if the IP is important, it might need to be obtained at every request.