search

un7c0rn / stopthevirus

Objective: Design a global scale social game to help inspire millions of Millennial and Gen-Z individuals across the world to engage in social distancing in order to stop the spread of the COVID-19 virus.
MIT License
7 stars 2 forks source link

Cross browser testing #129

Closed dzx11 closed 4 years ago

dzx11 commented 4 years ago

@bernardbaker I'll be using this issue to document any issues I find in the front end for this sprint.

dzx11 commented 4 years ago

🐛 Horizontal scroll bars appear on 1920x1080 resolution at 100% zoom (the rules text at the bottom of the page is too wide) 🐛The join game page throws an error on loading (Unhandled Rejection (Error): error with game info request) bug

bernardbaker commented 4 years ago

Great work.

Regarding the error. Are you using a valid game ID?

That is a custom error that should display a custom UI in the event of an error.

And it shouldn't be shown in production mode.

On Tue, 12 May 2020, 09:32 dzx11, notifications@github.com wrote:

🐛 Horizontal scroll bars appear on 1920x1080 resolution at 100% zoom (the rules text at the bottom of the page is too wide) 🐛The join game page throws an error on loading (Unhandled Rejection (Error): error with game info request) [image: bug] https://user-images.githubusercontent.com/13459787/81661018-7c426800-9476-11ea-9d10-95443ac83e86.PNG

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/un7c0rn/stopthevirus/issues/129#issuecomment-627196280, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHNTTCBWBIVVVLV64LBXYLRRECR5ANCNFSM4M6TPCTQ .

dzx11 commented 4 years ago

No, I'm using "12" as an ID. What would be an example valid game ID for this page?

bernardbaker commented 4 years ago

I'll get one for you.

On Tue, 12 May 2020, 10:58 dzx11, notifications@github.com wrote:

No, I'm using "12" as an ID. What would be an example valid game ID for this page?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/un7c0rn/stopthevirus/issues/129#issuecomment-627240214, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHNTTH3MU2I2PPIP2GX3R3RREMVZANCNFSM4M6TPCTQ .

bernardbaker commented 4 years ago

0H3RzPqfq4dnf47BSgve

On Tue, 12 May 2020, 10:58 dzx11, notifications@github.com wrote:

No, I'm using "12" as an ID. What would be an example valid game ID for this page?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/un7c0rn/stopthevirus/issues/129#issuecomment-627240214, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHNTTH3MU2I2PPIP2GX3R3RREMVZANCNFSM4M6TPCTQ .

dzx11 commented 4 years ago

That works - I'll add it to the readme

bernardbaker commented 4 years ago

The readme shouldn't actually hold an ID it should be a placeholder.

This is because if test haven't been wrong then there may not be an ID matching in the database.

Put it in if you think it will be helpful.

Regards, Bernard Baker

On Tue, 12 May 2020, 15:31 dzx11, notifications@github.com wrote:

That works - I'll add it to the readme

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/un7c0rn/stopthevirus/issues/129#issuecomment-627382498, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHNTTCSEJPN6VLVKYRDK4TRRFMTFANCNFSM4M6TPCTQ .

un7c0rn commented 4 years ago

Closing for now I think the remaining work gets addressed during UAT.