Closed dzx11 closed 4 years ago
Hi guys,
I'll be working on all page layouts today.
Regards, Bernard
On Wed, 20 May 2020, 09:50 dzx11, notifications@github.com wrote:
Closes #137 https://github.com/un7c0rn/stopthevirus/issues/137 I'm working off the assumption that this should just be a simple function that takes in players and team size and divides them equally, so some of the code is taken from GameSimulator. @un7c0rn https://github.com/un7c0rn PTAL
You can view, comment on, or merge this pull request online at:
https://github.com/un7c0rn/stopthevirus/pull/138 Commit Summary
- Add MatchMaker interface and roundrobin imp, empty test
- Fix typos
- Implement working tests & round robin match maker
- Clean up code
- Refactor for team size, raise exception if insuff players and test
File Changes
- M backend/game_engine/matchmaker.py https://github.com/un7c0rn/stopthevirus/pull/138/files#diff-00a725f472efd964cf064874b269ef0b (38)
- A backend/test_matchmaker.py https://github.com/un7c0rn/stopthevirus/pull/138/files#diff-8a2c105b6efe71accae504ce29466218 (47)
Patch Links:
- https://github.com/un7c0rn/stopthevirus/pull/138.patch
- https://github.com/un7c0rn/stopthevirus/pull/138.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/un7c0rn/stopthevirus/pull/138, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHNTTG63NLGV6RI3TGC2FDRSOKU3ANCNFSM4NFXKYBQ .
@bernardbaker Awesome! @dzx11 Looking at this as well as your design doc now. Thanks!
Hi,
Getting started after lunch. All pages will be updated in a few hours.
Regards,
Bernard T. A. Baker
On Wed, May 20, 2020 at 1:40 PM un7c0rn notifications@github.com wrote:
@bernardbaker https://github.com/bernardbaker Awesome! @dzx11 https://github.com/dzx11 Looking at this as well as your design doc now. Thanks!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/un7c0rn/stopthevirus/pull/138#issuecomment-631448056, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHNTTBPHREQTNXGZKWEXDLRSPFTTANCNFSM4NFXKYBQ .
Closing because merging this into https://github.com/un7c0rn/stopthevirus/pull/162
Closes #137 I'm working off the assumption that this should just be a simple function that takes in players and team size and divides them equally, so some of the code is taken from GameSimulator. @un7c0rn PTAL