un7c0rn / stopthevirus

Objective: Design a global scale social game to help inspire millions of Millennial and Gen-Z individuals across the world to engage in social distancing in order to stop the spread of the COVID-19 virus.
MIT License
7 stars 2 forks source link

first pass full game simulation using emulated players. #177

Closed un7c0rn closed 4 years ago

un7c0rn commented 4 years ago

untested but once this passes, all we need to do is:

un7c0rn commented 4 years ago

Updated. Integration tests still not passing but much further along. @dzx11 @bernardbaker PTAL

Screen Shot 2020-09-15 at 2 51 40 AM Screen Shot 2020-09-15 at 2 49 53 AM Screen Shot 2020-09-15 at 2 51 56 AM
bernardbaker commented 4 years ago

@un7c0rn that looks fantastic.

un7c0rn commented 4 years ago

@un7c0rn that looks fantastic.

@bernardbaker Thanks Bernard!

bernardbaker commented 4 years ago

It really does! Great work.

Regards,

Bernard T. A. Baker

On Tue, Sep 15, 2020 at 10:55 PM un7c0rn notifications@github.com wrote:

@un7c0rn https://github.com/un7c0rn that looks fantastic.

Thanks Bernard!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/un7c0rn/stopthevirus/pull/177#issuecomment-693000652, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHNTTEQSNTX7FBN6FE3LELSF7PGDANCNFSM4RL6JEDQ .

un7c0rn commented 4 years ago

@un7c0rn LGTM. The only issue is that Sentry free tier has a limit of 50k errors per month and we might go over that. Maybe moving the integration test to a separate branch and having the master branch not log to Sentry could be a good idea.

Also I noticed that there were some code formatting changes. Have we decided on a linting tool or style guide for the Python side?

@dzx11 Agreed I turned off Sentry (hit the limit pretty quick with integration testing). Yea I enabled auto PEP8 formatting in my IDE so that's where the format changes are coming from.