search

una-auxme / paf

Praktikum Autonomes Fahren - PAF
MIT License
9 stars 0 forks source link

[Bug]: CI/CD - Build step takes up to 14min - Caching not working #423

Open niklasr22 opened 2 weeks ago

niklasr22 commented 2 weeks ago

Current Behavior

The Test build step of the .github/workflows/build.yml workflow takes up to 14min to complete. It seems like the caching that was implemented in #353 does not work as docker never mentions that any of the build steps is read from the cache. I think it might be that the cache directories created in Create cache directory and Clean up cache are only created inside the filesystem of the container that runs the job but not stored in a volume on the host.

Expected Behavior

The pipeline step successfully reads/writes layers from/into the docker cache.

How to reproduce the issue

No response

ll7 commented 2 weeks ago

We should consult @JulianTrommer regarding the cashing.

niklasr22 commented 2 weeks ago

Maybe, in addition, we could also add a paths filter to the entire workflow. We could filter for changes in the code directories (maybe others as well). This would prevent this potentially long-running step from being executed even though only documentation files have changed.

ll7 commented 1 week ago

https://github.com/una-auxme/paf/blob/df9452db0529aef62312d8cae9b0f02cc2688af0/.github/workflows/build.yml#L45-L106

ll7 commented 1 week ago

We are now down to 8 minutes and run three build jobs in parallel, thanks to @JulianTrommer . How important do you think this issue is now? What would be a build time that is good enough?