search

una-dinosauria / human-motion-prediction

Simple baselines and RNNs for predicting human motion in tensorflow. Presented at CVPR 17.
MIT License
407 stars 141 forks source link

a question about fkl code? #52

Open willmao2013 opened 5 years ago

willmao2013 commented 5 years ago

Hi Julieta,

Thank you for releasing your code.

I am a little bit confused about these code in fkl.

https://github.com/una-dinosauria/human-motion-prediction/blob/c9a2774fe59bb78c6ec6d04e15f2cb7243c4348c/src/forward_kinematics.py#L41-L43 https://github.com/una-dinosauria/human-motion-prediction/blob/c9a2774fe59bb78c6ec6d04e15f2cb7243c4348c/src/forward_kinematics.py#L48

In angles variable, there should only be expmap of rotation matrix for each joint except for the first three elements. Why these code use some of the elements as the positions of the joints?

Thank you Wei

una-dinosauria commented 5 years ago

Hi! Please see https://github.com/una-dinosauria/human-motion-prediction/issues/26#issuecomment-381436386

I believe this is a mistake I made. If you fix it please consider submitting a PR request.

Note that this code is used for visualization only, so it does not affect training/validation.

Cheers,