una-xiv / umbra

Umbra XIV - Adds quality of life improvements to the game and consolidates common UI elements and actions into a single uniform interface.
GNU Affero General Public License v3.0
51 stars 18 forks source link

[Feature Request] Mute/unmute specific sound channels via volume control right-click #103

Open HawkAtreides opened 1 month ago

HawkAtreides commented 1 month ago

I'd like to be able to use the Umbra mute/unmute feature to mute specific channels other than the master volume when right-clicking the volume control button. My specific use case is that I like to leave the System channel unmuted when otherwise muting the game client, and currently have to use a macro that invokes multiple SoundSetter toggle commands to mute and unmute only the non-System channels. I could see this implemented in one of two ways:

My personal preference would swing toward the opt-out feature, as my use case exempts only one channel from muting and so the 'lock' paradigm would require fewer explicit declarations, but I'm aware that both cases would require that the right-click function be rewritten to acknowledge the opt-out/-in state, with a fallback to the current behavior of the Master channel being muted if no channels are explicitly exempted/included.