search

una-xiv / umbra

Umbra XIV - Adds quality of life improvements to the game and consolidates common UI elements and actions into a single uniform interface.
GNU Affero General Public License v3.0
59 stars 24 forks source link

[BUG] Eureka Coffers don't function in other languages than English #11

Closed haroldiedema closed 1 month ago

haroldiedema commented 2 months ago

The visible Eureka Coffers work based on the chat message / notification that is produced when using the Lucky Carrot. This currently only works in English because it simply strips out the direction and distance from the text.

The relevant code is here and should be relatively trivial to fix for other languages. https://github.com/una-xiv/umbra/blob/main/Umbra/src/Markers/Factories/EurekaCoffersWorldMarkerFactory.Filter.cs#L36

haroldiedema commented 2 months ago
  1. Figure out the function that prints the message and hook into it.
  2. Query the LogMessage sheet for the correct row.
  3. Figure out which arguments are passed and how they relate to distance & direction.

image

haroldiedema commented 2 months ago

https://github.com/aers/FFXIVClientStructs/blob/main/FFXIVClientStructs/FFXIV/Client/UI/Misc/RaptureLogModule.cs#L56

haroldiedema commented 2 months ago

Tried hooking the RaptureLogModule functions, but unfortunately they aren't being invoked when using the Lucky Carrot.

haroldiedema commented 1 month ago

Fixed in V2.