[Bug] Incorrect GC seal cap

una-xiv / umbra

Umbra XIV - Adds quality of life improvements to the game and consolidates common UI elements and actions into a single uniform interface.

GNU Affero General Public License v3.0

51 stars 18 forks source link

[Bug] Incorrect GC seal cap #26

Closed foophoof closed 1 month ago

foophoof commented 2 months ago

It looks like the cap in the currency tab for GC seals is wrong, it's showing 200,000, but the cap for me currently is 90,000 (which I think is the max cap?)

Screenshot of currency tab in Umbra, showing 78,967 / 200,000 flame seals

I'm on v1.0.0.2.

haroldiedema commented 2 months ago

I think GC seals require some custom logic for them because the cap is based on your GC rank. Apart from detecting which GC you are a member of, I haven't worked on anything else related to this yet.

haroldiedema commented 1 month ago

https://github.com/NotAdam/Lumina.Excel/blob/master/src/Lumina.Excel/GeneratedSheets/GrandCompanyRank.cs

haroldiedema commented 1 month ago

Fixed in the upcoming 2.0 version.