[Feature Request] option to list residential teleports instead or in addition to travel shortcuts

una-xiv / umbra

Umbra XIV - Adds quality of life improvements to the game and consolidates common UI elements and actions into a single uniform interface.

GNU Affero General Public License v3.0

59 stars 24 forks source link

[Feature Request] option to list residential teleports instead or in addition to travel shortcuts #7

Closed LTS-FFXIV closed 2 months ago

LTS-FFXIV commented 2 months ago

This list

Showing these teleports instead, or in addition to (also if residential teleports could be renamed that'd be sick)

haroldiedema commented 2 months ago

I've tried to implement this, but managed to only get it working for an apartment and not an FC house. I need to spend some more time with this after the DTR bar implementation.

If you're comfortable with the code, you can find the relevant code here: https://github.com/una-xiv/umbra/blob/main/Umbra.Game/src/MainMenu/MainMenuRepository.cs#L112

I thought it would be just as simple as checking if aetheryte.IsSharedHouse and aetheryte.IsAppartment, but that doesn't seem to work for all cases from what I could test locally. Feel free to try this for yourself to see if you have more luck.

That said, I rather have a fully working estate list instead of just apartments. People will complain if they see only some of the residential options there instead of all of them.

LTS-FFXIV commented 2 months ago

May want to look into how teleporterplugin populates residential teleports and allows for stuff like /tp home https://github.com/pohky/TeleporterPlugin/blob/master/TeleporterPlugin/Managers/AetheryteManager.cs

haroldiedema commented 2 months ago

I've added residential areas to the travel menu in https://github.com/una-xiv/umbra/commit/bf9dcc32322bf29037140f71c9ae2504e9c12bea

You'll need to enable the option in Toolbar Settings:

Would you mind testing this? I don't have access to shared/private estates on my account 😅

LTS-FFXIV commented 2 months ago

Only one of the shared estates is appearing The private estate is ??? Apartment is not appearing

haroldiedema commented 2 months ago

Can we discuss this on Discord? My id is liscion, or find me as Una in the dalamud discord. May speed things up a bit, since I can't really test this locally without spending millions of gil and waiting for lottery periods 😅

haroldiedema commented 2 months ago

I've pushed an update that hopefully fixes it.

haroldiedema commented 2 months ago

Fixed by https://github.com/una-xiv/umbra/pull/8

Thanks for the help! 😄