una-xiv / umbra

Umbra XIV - Adds quality of life improvements to the game and consolidates common UI elements and actions into a single uniform interface.
GNU Affero General Public License v3.0
51 stars 18 forks source link

Location widget doesn't detect landmarks inside duties #82

Closed SabSparrow closed 1 month ago

SabSparrow commented 1 month ago

The location widget doesn't seem to detect landmarks in some duties. For instance, if I enter Sastasha and enter the Empty Room near the start, it'll still show Wauling Pond. This is inconsistent with the behavior outside of duties.

haroldiedema commented 1 month ago

This changed since the last update to increase performance to detect your current sub-territory. Previously I was continuously scanning for nearby map pins to determine what to show. Since the last update, it is using the territory name reported by the game itself instead.

The previous way had a lot of false-positives. In your example, Empty Room would still be shown even if you were in the corridor above it, just because the map pin would be closer by compared to the text location of the "Wauling Pond".

image

Closing this, since it's currently working as intended.

SabSparrow commented 1 month ago

No, this is an actual bug, I'm in the actual room and not the corridor. I've attached a screenshot that illustrates the issue, where I've just entered the Empty Room. empty room It works just fine outside duties, as illustrated by the next screenshot. aftcastle

SabSparrow commented 1 month ago

Ah, I was wrong about it applying only in duties, it seems to be an issue where it detects the first subsection and not the second... That wouldn't be an issue if the game used those consistently, but sometimes it's used for areas and sometimes it's used for landmarks. Here's an example of it happening in Middle La Noscea. zephyr

SabSparrow commented 1 month ago

I guess it may be desirable to prioritise the larger sections over landmarks, so maybe it's not a bug after all.