una-xiv / umbra

Umbra XIV - Adds quality of life improvements to the game and consolidates common UI elements and actions into a single uniform interface.
GNU Affero General Public License v3.0
83 stars 30 forks source link

Some i18n questions #9

Closed AinaSnow closed 5 months ago

AinaSnow commented 5 months ago

I've found some problems with i18n that only occur in other languages.

  1. When the client language is Japanese, the currency button does not work, when I click the currency button, the weather menu pops up, after switching the client language to English, the problem disappeared. Initially, the problem is in the size of the menu buttons (because the menu buttons get their content directly from the game, but the Japanese menu names are longer, I'm not sure if this is the reason). 30671ca77158a85a4fea17690d09db28 64925a7ae025325d1620e5aa612bc851

  2. Is it possible to add settings to i18n content without using the dalamud language settings obtained from dalamud? (This is kind of a niche issue I think, if my dalamud language is set to Chinese and the game language is Japanese, because there is no zh i18n file, it will automatically use the default value of English, I created my own i18n file, but because of the problem between dalamud and the game itself, some fonts will be missing, is it possible to add settings to the i18n of umbra? Can you add a separate setting for i18n in umbra?)

haroldiedema commented 5 months ago

Thanks for the findings!

The reason why the currency button does not work is because the weather/location widget is overlapping it. The widget in the center has a fixed size of over 500px, so on smaller screen resolutions/windows, they will overlap. I'll see if I can write a fix for this by making the fixed size a bit smaller.

but because of the problem between dalamud and the game itself, some fonts will be missing

I don't really understand what you mean by this. If I understand correctly, you're asking for an options to override the client language in Umbra settings?

Most of the elements in Umbra come from the game itself (menu items, currency names, etc.) so they don't have custom translations. This means that if the selected language in Umbra does not match Dalamud's, there will be some mixed languages being used. I don't think there's much else you can do besides adding a zh.json file with the Chinese translations.

AinaSnow commented 5 months ago

The text in the plug-in is divided into two parts, one part is obtained directly from the game, and the other part is i18n content. I wonder if the user can choose what language to use for the i18n part instead of using dalamud's language setting. The fonts in the i18n part are mixed between the game and dalamud itself, so if this part is a game, content will be lost. In fact, this problem does not only appear in Chinese. If there is no i18n in the game outside of JEDF, it will be an error. {93AA2D61-9999-4201-A5AB-19397FCEE273} QQ截图20240423152255

haroldiedema commented 5 months ago

All elements in Umbra use the Axis font, which the game uses as well. I'm not quite sure how modifying the language would solve this to be honest 🤔

AinaSnow commented 5 months ago

My idea is to allow users to choose the language selection for the i18n part for example https://github.com/Caraxi/SimpleTweaksPlugin 2ff8607dce65ea2004e72706d18a62a1

haroldiedema commented 5 months ago

Yes, I understand that. I just don't understand how that is going to solve the missing glyphs in the screenshots you posted earlier? Maybe I'm missing something.

If you create a zh.json file, it should automatically load that if you set the dalamud language to Chinese, right?

AinaSnow commented 5 months ago

yep but Axis font The support for Chinese is not very good, so there will be deficiencies

AinaSnow commented 5 months ago

So my idea is if I can add a setting to allow i18n content to be different from the game itself language/dalamud language, example: game language: Japanese, dalamud language: Chinese, i18n language: Japanese

What I do now is to create zh.json and Copy the content in ja.json to zh.json to complete

haroldiedema commented 5 months ago

game language: Japanese, dalamud language: Chinese, i18n language: Japanese

Ah, now I understand. I was under the impression that you wanted to use zh in Umbra. I'll see if I can make an i18n switcher in the config. 😄

AinaSnow commented 5 months ago

thx