search

unabridged / motion

Reactive frontend UI components for Rails in pure Ruby
https://github.com/unabridged/motion
MIT License
697 stars 19 forks source link

Compatibility issue with Rails 6.1 ? #71

Closed mmagn closed 3 years ago

mmagn commented 3 years ago

Hi, first of all thank you for your work on Motion, your gem is really helpful and it is a pleasure to use it.

I am using the 0.4.4 version of the gem and everything is fine on Rails 6.0.3.

I tried to upgrade to Rails 6.1, but now my components are no longer updated after an interaction and sometimes the component disappears from the page.

I have investigated few hours without success, there is no error message in the logs...

I was able to reproduce my problem on a cloned repository of motion-demos : https://github.com/mmagn/motion-demos/

Am I missing something?

Thanks for your help.

latortuga commented 3 years ago

Thank you for the report and nice words! We have not yet tested with Rails 6.1 so that would explain why it doesn't work yet. We'll put it up on the priority list!

EtienneDepaulis commented 3 years ago

Hello, we have the same issue as well : no more live update :/

dannyvanhoof commented 3 years ago

Similar problem: update leaves completely empty component...

HashNotAdam commented 3 years ago

So far I've managed to work out that the difference is that now the whole page is being rendered instead of just the component which is confusing the DOM differ

dannyvanhoof commented 3 years ago

All - I hesitate to write it - but I have the impression motion is not actively maintained? 6.1 is out since December - and the only gem blocking us from the new release is motion... Did we make the wrong choice to rely on motion in our product? When we made that choice, the functionality looked so attractive - and it still is - but without active maintenance it becomes a problem :-(

HashNotAdam commented 3 years ago

All - I hesitate to write it - but I have the impression motion is not actively maintained? 6.1 is out since December - and the only gem blocking us from the new release is motion... Did we make the wrong choice to rely on motion in our product? When we made that choice, the functionality looked so attractive - and it still is - but without active maintenance it becomes a problem :-(

Being an open-source product, you could always help with the maintenance. I've already done the hardest part of the work but require support getting it over the line.

Even just trying out my fork and reporting any bugs I may have missed would be helpful

dannyvanhoof commented 3 years ago

I integrated your fork in our application, and ran the entire test suite in Rails 6.1. All tests completed succesfully - so we are eagerly waiting for you to officially release #73!

latortuga commented 3 years ago

Thanks for the reports and contribution all, we'll hopefully be able to get this resolved in the near future!

HashNotAdam commented 3 years ago

Thanks for the reports and contribution all, we'll hopefully be able to get this resolved in the near future!

Thanks, @latortuga, I might be able to get more time to look at it this week but even if someone could job on the PR and explain how the test system works, that would save me a tonne of time finishing off the PR. Otherwise, I'll try to set a day aside to dig into it

dannyvanhoof commented 3 years ago

@latortuga Any progress with testing/releasing the 6.1 changes?

zog commented 3 years ago

Hey @HashNotAdam ,

I'm willing to help solving this issue, unfortunately I was unable to reproduce the failing specs on my local machine (matching ruby version etc.). Any pointer ?

latortuga commented 3 years ago

Apologies for the lateness on this folks but we have pushed out a fix for Rails 6.1 today. Please upgrade to v0.5 and give it a try!