search

unabridged / motion

Reactive frontend UI components for Rails in pure Ruby
https://github.com/unabridged/motion
MIT License
697 stars 19 forks source link

Add infos on unserializable components #72

Closed zog closed 3 years ago

zog commented 3 years ago

When a component fails to be serialized, one can have a hard time determining which of the component's ivars is the one causing the issue. Here, I propose to add this information in the error message.

latortuga commented 3 years ago

I like this approach of reporting more details in the error message!

latortuga commented 3 years ago

@zog can you rebase this so we can get a green build now that main has the intermittent test failures fixed?

clottman commented 3 years ago

Hi @zog, thanks again for submitting this. We'd love to get it merged in - would you mind rebasing/merging with main to get our CI passing so we can do that?

clottman commented 3 years ago

Actually I figured out how to edit the PR myself to do the merge! 😄 Had to check out using the PR name and the github cli instead of the branch name.