Port to 1.16

[pupnewfster]

Decided I might as well PR this back up stream now that I think I am done fixing this (probably makes sense to add a 1.16 branch that I can target). I started with @xbony2 's WIP 1.15 branch, and updated it to 1.16 fixing various issues. Some of the larger changes are listed below:

• Changed away from using a messy recreation of a dirt screen for loading (in part given I couldn't get it working), to using a custom loading screen. This loading screen still shows the title/subtitle, and item name, but also now shows a preview of the item.
• Changed bulk rendering to render it batches of 7 items per tick instead of all items per tick (so that MC can actually render other stuff such as the loading screen)
• Moved saving the images to not being done on the main game thread (both for bulk and individual)
• Changed lang keys to include blockrenderer in them so that they don't accidentally intersect
• Made the mod properly NO-OP on servers, and not cause a red x to show when pinging a server without the mod when the client has it installed.

One thing to note that the person who was testing a WIP version of this while I was working on it is that it doesn't work correctly on Macs though it works fine on windows. Not sure if it is something specific about their software, or just Macs in general but as I don't have a Mac so I can't really look into this further/try to debug it.

[unascribed]

Geez, this is extensive. Basically a complete rewrite.

This even having my name on it feels kind of disingenuous, honestly. As much as I like Curse points (apparently BlockRenderer has all its points going to what used to be buildcraftchildsplay), it feels like the right thing to do here would be to publish this mod separately and I can link it from my BlockRenderer spaces. Unless you really really want me to manage releases.

[pupnewfster]

Up to you, personally I don't really do much rendering stuff and got a bit distracted while porting it (so went a bit overboard). So if I were to release it all it would be is "maintaining" in terms of in its current form as I wouldn't end up adding any other features (such as are requested in your issue tracker), and not sure if I would end up updating it to 1.17 either given who knows if I will still need it then.

All in all I think it might just be simpler to continue having it be from the main BlockRender location, especially given I am not currently looking for more mods to help teach people how to use/debug why they don't know how to read and press buttons on their keyboard (unfortunately I have ran into too many users like this).

[xbony2]

If it doesn't work on Macs I can try to debug that btw. Anyway regarding the above I'm not invested in either, just would be nice to have this on CurseForge so I can use it in my pet project.

[unascribed]

re: pupnewfstr

Yeah, that all makes sense. I'll make a new branch and either manual-merge this or retarget the PR.

re: xbony2

It would be nice to know why it doesn't work on Macs, feels a little silly to release a mod that just doesn't work on one platform. Would also be nice if Cocoa and macOS' OpenGL implementation weren't so troublesome, but y'know.

[pupnewfster]

Ya not sure what is going on with the mac thing, for all I know it could have just been one very specific setup or maybe it is all macs just figured it was worth mentioning.

[xbony2]

At least we don't have to use PowerShell ;p

[AterAnimAvis]

Just as a side note. I've got a ~port~ fork over at https://github.com/AterAnimAvis/BlockRenderer and CurseForge for versions 1.14 -> 1.16 (+ Fabric 1.16) (via https://github.com/unascribed/BlockRenderer/issues/24).

[unascribed]

So you do; I forgot about that, and it's an untagged fork so I didn't see it when looking at this repo's network.

[unascribed]

Added a link to the Curse page.

[AterAnimAvis]

No problem, thats probably my fault. Feel free to take anything from my fork if you want to continue with this, I've got a Animated and Map Renderer which you might want to look at (Although the Animated one isn't the cleanest).

[unascribed]

I don't really want to maintain this, let alone manage the Fabric/Forge split, so.

Might try and help with entity and structure rendering on your fork at some point; seems you've already got some amount of it working, and that was my primary interest in picking this back up.

[AterAnimAvis]

I've managed to reduce the Fabric/Forge split quite a bit. Check the https://github.com/AterAnimAvis/BlockRenderer/tree/1.16-merged-official WARNING: OFFICIAL MAPPINGS Most of the differences now stem done to different ClassNames and different packages (Need to be in seperate packages so I can publish a single jar for Fabric/Forge) Feel free to target whatever your comfortable with (or one of the other branches), I'll happily port across any contributions. (Most of my Structure/Entity render code is for 1.15, no where near complete and was for an older design of BR I can probably resurrect most of it, IIRC I stopped then due to the fact that ServiceLoader mechanism with ModLauncher was broken at that point)

[pupnewfster]

Ah I had not even noticed that there was an already ported fork of this given the github repo's aren't linked under the list of forks.

[AterAnimAvis]

Again probably my fault. I started a private fork initially which for whatever reason I made unlinked, once I had ported it I squashed down and made it public, however it doesn't show up as a fork due it originally being unlinked. 🤷 it didn't really matter to me so I haven't tried to undo/fix it.