unassert-js / unassert

Encourages programming with assertions by providing tools to compile them away.
MIT License
192 stars 13 forks source link

[Fix] fix "exports" for node 13.0-13.6 #41

Closed ljharb closed 1 year ago

ljharb commented 1 year ago

This commit allows these node versions to work.

ljharb commented 1 year ago

cc @goto-bus-stop :-)

ljharb commented 1 year ago

oh noes! cc @twada

falsandtru commented 1 year ago

ping @twada

RebeccaStevens commented 1 year ago

From the support-policy

We support Node under maintenance. In other words, we stop supporting old Node version when their maintenance ends.

Thus I don't think this PR will be getting merged. Node 13 isn't in LTS and Node 14 is going to be leaving LTS in a month. If you need this functionality, I'd recommend using a patch. See pnpm patch or yarn patch.

ljharb commented 1 year ago

@RebeccaStevens Support policy is irrelevant; engines.node dictates support and semver says that whatever works must continue working.

Patching installed modules live is FAR worse than forking them, ftr.

ljharb commented 1 year ago

ping @twada; this is continuing to cause failures in some of my projects' CI, and i'd love it to be fixed.

I'd be more than happy to help you maintain this package if you're short on time!

twada commented 1 year ago

@ljharb Thank you for pinging me! I've been sick and absent recently, but will be rebooting now! Thank you everyone in this issue. I'll cut a release soon.

ljharb commented 1 year ago

<3 thank you! glad you're feeling better :-)

twada commented 1 year ago

Support policy is irrelevant; engines.node dictates support and semver says that whatever works must continue working.

This is reasonable. engines.node must be defined explicitly. I'll work on this in next major.

twada commented 1 year ago

unassert 2.0.1 is out. Thank you @ljharb ! https://github.com/unassert-js/unassert/blob/master/CHANGELOG.md#201-2023-04-19

ljharb commented 1 year ago

@twada i filed #46 as a followup - my apologies that further tweaks are needed.