unbaiat / skipfish

Automatically exported from code.google.com/p/skipfish
Apache License 2.0
0 stars 0 forks source link

Segfault when no auth_user_field is found #168

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
When doing 
https://code.google.com/p/skipfish/wiki/Authentication#Form_authentication on a 
form which has a username field other than in auth.h, skipfish goes into a loop 
of some sort and then segfaults after while.

Here's my login form fields:
Username: name="login[login]"
Password: name="login[password]"

From the log below we can see it finds password field without an issue but it 
never finds the username field.

Here's a snippet of debug data:
* collect_form_data() entered
--- NEW PROBLEM - type: 10602, extra: '(null)' ---
*-- Authentication - using pass field: login[password]
* collect_form_data() entered
--- NEW PROBLEM - type: 10602, extra: '(null)' ---
* collect_form_data() entered
--- NEW PROBLEM - type: 10602, extra: '(null)' ---
* collect_form_data() entered
--- NEW PROBLEM - type: 10602, extra: '(null)' ---

This is how it looks when run from the command line:
*- Authentication starts
*-- Authentication - using pass field: login[password]
[-] PROGRAM ABORT : Out of memory: can't allocate 124 bytes
    Stop location : __DFL_ck_alloc(), src/alloc-inl.h:88
Aborted

Perhaps some sort of loop check or something could solve this issue?

Original issue reported on code.google.com by matthew....@gmail.com on 3 Dec 2012 at 8:15

GoogleCodeExporter commented 8 years ago
Thanks for reporting! This should be fixed in SVN, could you test this?

$ svn checkout http://skipfish.googlecode.com/svn/trunk/ skipfish-read-only

Original comment by niels.he...@gmail.com on 3 Dec 2012 at 8:35

GoogleCodeExporter commented 8 years ago
That was fast. Yes, it works now. No loops no segfaults. Thanks.

Original comment by matthew....@gmail.com on 3 Dec 2012 at 8:43

GoogleCodeExporter commented 8 years ago
Awesome and thanks for reporting!!

(I promise to release the 2.10 version tomorrow ;p)

Original comment by niels.he...@gmail.com on 3 Dec 2012 at 10:06