unbalancedparentheses / data_science_in_julia_for_hackers

Data Science in Julia With Hackers

https://datasciencejuliahackers.com

114 stars 25 forks source link

Chap 7 feedback #144

Open salbert83 opened 3 years ago

salbert83 commented 3 years ago

I believe the following code:

Team-specific effects

att ~ filldist(Normal(μatt, σatt), length(teams))
def ~ filldist(Normal(μatt, σdeff), length(teams))

should be changed to

Team-specific effects

att ~ filldist(Normal(μatt, σatt), length(teams))
def ~ filldist(Normal(**μdef**, σdef), length(teams))

Otherwise, I believe there may be a convergence issue.

unbalancedparentheses commented 3 years ago

Hi @salbert83, first of all thanks for taking the time to read the book and for the feedback. We will check this in the following and solve it.

Fede.

salbert83 commented 3 years ago

Also, regarding this line: "posterior = sample(model, NUTS(),3000);" perhaps a comment that this could take some time depending on one's machine. Thanks for making this preview available.