search

unbekanntes-pferd / dccmd-rs

dccmd-rs (DRACOON Commander) – a CLI client for DRACOON (https://dracoon.com) written in Rust
4 stars 1 forks source link

feat(upload): add flag for preserving share links #17

Closed oliverziegert closed 5 months ago

oliverziegert commented 5 months ago

The current implementation for retaining share links restricts flexibility. It would be helpful to be able to specify whether existing share links should be preserved, regardless of the conflict resolution method.

unbekanntes-pferd commented 5 months ago

Thanks for the contribution - I'll add this to the next version and document it. Currently, CI fails due to a linting issue unrelated to the code committed - I'll fix it after the merge.

unbekanntes-pferd commented 5 months ago

For doc purposes: the flag --keep-share-links only makes sense if --overwrite is used - for the other resolution strategies (fail, autorename) it does not apply. Therefore, the flag is only read in that case and ignored otherwise. This now makes the default behavior to not keep share links by default on overwrite - it is necessary to explicitly pass the flag as proposed. Released with #18