search

unbelievableflavour / bookmark-manager

A manager for the bookmarks in your .ssh/config file for elementaryOS
GNU General Public License v3.0
27 stars 8 forks source link

Not works with tilix #52

Open Aleksandr-ru opened 4 years ago

Aleksandr-ru commented 4 years ago

I'm using tilix as my default terminal. When I press "start ssh session in a terminal" button in the bookmark manager notnong happends.

If I run bookmark manager via console there is error about unknown parameter execute when I press start session, but nothnig in GUI.

If I chnage terminal in preferences from '/usr/bin/tilix' to 'io.elementary.terminal' it works fine with default elementary terminal.

greenmanspirit commented 3 years ago

This is because tilix doesn't support the --execute command line argument. I looked at tilix, io.elementary.terminal, xterm, gnome-terminal, rxvt, urxvt and terminator and they all support "-e " to run a command. However gnome-terminal has deprecated it in favor of using "-- " at the end of the line.

I made an edit to use -e instead and tested it. All the terminals above worked except for urxvt and rxvt, which appear to not like launching ssh using -e from the terminal either.

unbelievableflavour commented 3 years ago

Maybe we can add a setting to change execute argument?

greenmanspirit commented 3 years ago

I think that would make it the most flexible. Maybe have a help tooltip to specify how to write -e <command> vs `--execute='.