unbit / foohid

OSX IOKit driver for implementing virtual HID devices (joypads, keyboards, mices, ...) from userspace
MIT License
264 stars 35 forks source link

Misc improvements #8

Closed btoews closed 7 years ago

btoews commented 7 years ago

This PR makes a few changes. Let me know if you'd like me to split this up into multiple, smallers PRs.

I also cleaned up a bunch of garbage whitespace throughout the project. This makes the diff kind of hard to read on GitHub. Appending ?w=1 to the URL hides the whitespace changes from the diff, making it easier to read.

I'll be opening a separate PR to implement the setReport stuff.

btoews commented 7 years ago

Here's a branch adding setReport support. It's based on this branch, so I can't cleanly open a PR until this one merges.

aldur commented 7 years ago

Thanks! I reviewed the changed files, but I didn't test the new kext (I don't have a macOS install available ATM). @unbit, what do you think?

unbit commented 7 years ago

The patch seems good but i need to test it :) I will check it during the week-end

btoews commented 7 years ago

@unbit Cool, thanks. Would you like me to include the setReport changes in this PR or do that in a separate PR once this one merges?

btoews commented 7 years ago

This PR ended up mostly being aesthetic changes that aren't really important. I opened another PR (https://github.com/unbit/foohid/pull/9) to implement the setReport call, which is what I'm really interested in :smile:. I'm closing this PR for now.