search

unblocked-web / double-agent

A test suite of common scraper detection techniques. See how detectable your scraper stack is.
MIT License
135 stars 10 forks source link

update puppeteer to latest version (13+) #61

Closed GlenDC closed 2 years ago

GlenDC commented 2 years ago

Currently the puppeteer version in this repo's runner implementation for puppeteer is at a very old version (v2), while we're already 11 major versions further (v13). As can be seen at https://www.npmjs.com/package/puppeteer.

I tried this locally on my own repo (which makes use of double-agent) and that seems to work fine without any changes. Only thing that did change is that the assignments result in generating a storm of pop-ups for saving a downloaded file, so that's the only thing that I notice that probably does require addressing somehow.

blakebyrnes commented 2 years ago

Assuming we are still using Axios to get all the assignments and results, I wonder how/where that's turning into something puppeteer sees.

GlenDC commented 2 years ago

I wonder how/where that's turning into something puppeteer sees.

No clue. Must be something that's happening on the page. But I do wonder why that is happening with the latest puppeteer version and not the very old one used on the current main/master version of your project.

blakebyrnes commented 2 years ago

Fixed in latest push