search

unblu / ucascade

Working with multiple main branches on GitLab
https://unblu.github.io/ucascade
Apache License 2.0
17 stars 7 forks source link

Use correct JDK version in Dockerfiles. #14

Closed dmitchellmim closed 1 year ago

dmitchellmim commented 1 year ago

These Dockerfiles used Java 11, but build.gradle specifies Java 17, so the Dockerfiles failed to run the application. This fixes that, updating the Dockerfiles to use Java 17. (Also, the -runtime version is about 41 MB smaller.)

gysel commented 1 year ago

@jmini @fbpe did we not notice this because we use JIB to build the images?

jmini commented 1 year ago

As written on page: https://github.com/unblu/ucascade/blob/main/_documentation/src/docs/tech-docs/50_build.adoc

We are building with:

./gradlew build \
    -Dquarkus.container-image.build=true \
    -Dquarkus.container-image.push=true \
    -Dquarkus.container-image.registry=<registry name> \
    -Dquarkus.container-image.group=<image path> \
    -Dquarkus.container-image.name=<image name> \
    -Dquarkus.container-image.username=<registry username> \
    -Dquarkus.container-image.password=<registry password>

And then I think that because io.quarkus:quarkus-container-image-jib is added as dependency it uses JIB to build the docker image.

So those docker files are some leftovers from the initial template https://code.quarkus.io that was used.