search

unblu / ucascade

Working with multiple main branches on GitLab
https://unblu.github.io/ucascade
Apache License 2.0
17 stars 7 forks source link

Catch all endpoint is conflicting with the health check endpoints #6

Closed jmini closed 1 year ago

jmini commented 1 year ago

We have introduced a catch-all route to still answer OK in case of an invalid path:

https://github.com/unblu/ucascade/blob/19035e27711601f24098f1590686afb2960cc2a3/src/main/java/controller/MergeRequestController.java#L60-L69

But this is conflicting with the default health check endpoints (/q/health/live and /q/health/ready) that are configured with the built in extension:

https://github.com/unblu/ucascade/blob/19035e27711601f24098f1590686afb2960cc2a3/build.gradle#L19

As a result we see following entries in the logs:

2023-03-23 10:27:30,685 INFO  [con.MergeRequestController] (vert.x-eventloop-thread-0) GitlabEvent: 'null' | Invalid path '/q/health/live'
2023-03-23 10:27:30,685 INFO [con.MergeRequestController] (vert.x-eventloop-thread-1) GitlabEvent: 'null' | Invalid path '/q/health/ready'